https://bugzilla.redhat.com/show_bug.cgi?id=1510565 Pavel Zhukov <pzhukov@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Pavel Zhukov <pzhukov@xxxxxxxxxx> --- (In reply to Miroslav Lichvar from comment #11) > Thanks for the review. > > The Makefile doesn't support DESTDIR and the upstream is not interested in > adapting autoconf+automake only to install a single shell script :). If > %install used "make install prefix=...", the bindir and mandir variables > wouldn't be set to %{_bindir} and %{_mandir}. I think that's why the > %makeinstall macro exists. > > Does that make sense? I'm fine with it. But packaging guidelines asks for clarification. Looks good. > > To avoid starting with a lowercase character I'll change the description to: > > This package contains a script which prints a brief summary of the system > > clock's synchronisation status when the ntpd or chronyd daemon is running. Ok. Please change the description in initial commit then. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
