https://bugzilla.redhat.com/show_bug.cgi?id=1519346 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- .so symlink is deleted. I understand why, but at the same time, this will make it harder to build C extensions for this version. And C extensions is something that people will want to test against the new version too. Not sure what to do about this. > %defattr(-,root,root,-) > %defattr(-,root,root,755) Not needed. Since this is essentially a version update from an existing package, I'm only looking at the changes. Licensing and description and all unchanged stuff can be assumed to be OK. + package name is OK + version is OK (3.7.0-0.1.a2) + no conflicts: stdlib is in /usr/lib64/python3.7 include files are in /usr/include/python3.7m/ and everything else is suffixed with the version. /usr/lib/rpm/macros.d/macros.pybytecompile3.7 will be included by rpm (all files in that directory are). But it's currently the same as the one provided by python3.6 and rpm has no issue with duplicated definitions, so this is not a problem. + Provides/Requires look OK + BuildRequires seem correct + installs and functions correctly Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
