https://bugzilla.redhat.com/show_bug.cgi?id=1447517 --- Comment #7 from sanford rockowitz <rockowitz@xxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #6) > - Not sure what is this for: > > rpm --version > rpmbuild --version - Purely informational, dating from the time I was trying to create a single rpm spec file that worked everywhere. Will remove. > - make DESTDIR=%{buildroot} install → %make_install Will change > > - no need for %attr(755,root,root)' just: > > %{_bindir}/ddcutil Will change > > - Since you're upstream, it would be best if your install script doesn't > install anything in docdir. It's better to do it in %files like this: > > %doc AUTHORS NEWS.md README.md ChangeLog > %license COPYING > > Files will then be copied automatically. > I don't know what's needed for other distro though so maybe it's not > possible. This one is problematic. At least for me, since packaging is not my thing. Will investigate the impact on other distros. A final question. When I upload the updated package, should I bump the release number from 1 to 2, given that the package is still under review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
