[Bug 1509290] Review Request: vmod-uuid - uuid module for varnish cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1509290

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Not sure why you grab a git commit instead of the release?
   Remove:

%global commit0 ec75dddf6c2fb634972962a3b8f10fd41c59bb61
%global shortcommit0 %(c=%{commit0}; echo ${c:0:7})
%global gitowner otto-de

   Then:

Source0:
https://github.com/otto-de/libvmod-uuid/archive/v%{version}/%{name}-%{version}.tar.gz

   And:

%autosetup -n lib%{name}-%{version}

 - Remove all the unnecessary commented out lines:

#Source0: vmod-uuid-1.3.tar.gz
#Patch0: vmod-uuid-1.3.fix_python_el6.patch

#setup -q -n %{name}-%{version}
#if 0%{?rhel} == 6
#patch0 -p0
#else
#endif

# Clean buildroot on older el variants
#rm -rf #{buildroot}

 - make → %make_build

 - make install DESTDIR=%{buildroot} → %make_install

 - find %{buildroot}/%{_libdir}/ -name '*.la' -exec rm -f {} ';'  → find
%{buildroot}/%{_libdir}/ -name '*.la' -delete 
find %{buildroot}/%{_libdir}/ -name  '*.a' -exec rm -f {} ';' → find
%{buildroot}/%{_libdir}/ -name  '*.a' -delete

 - Not needed:

%clean
rm -rf %{buildroot}

 - Not needed:

%defattr(-,root,root,-)

 - Not useful:

echo Upstream:
https://github.com/%{gitowner}/lib%{name}/archive/%{commit0}/lib%{name}-%{shortcommit0}.tar.gz

 - These versions are not available on Rawhide

%global varnishver 5.2.0
%global vabi 6.1
%global vabistrict 4c4875cbf

Thus the build fails. Should be:

%global varnishver 5.2.1
%global vabi 6.1
%global vabistrict 67e562482

Though, isn't there a way to relax this to be able to build on future versions?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux