Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sazanami-fonts - Sazanami Japanese TrueType fonts https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253163 ------- Additional Comments From petersen@xxxxxxxxxx 2007-08-23 04:05 EST ------- For reference the sazanami fonts are currently part of the fonts-japanese package in Fedora, so this not new content for Fedora per se, but will allow those fonts to be housed in their own package. Here is the review: Good - package follows upstream project name - spec filename matches package name - meets Packaging Guidelines - upstream license is BSD and included - spec file is well written - source tarball is identical to the current one included in fonts-japanese b312f77829011547b19fc16956dc6f12 sazanami-20061016.tar.bz2 (which fixes a bug in the last upstream release - see above bug) - noarch package and builds correctly - lists build dependencies - rest of filelist looks good (see below) - permissions correct - has %clean - consistent macro usage - tarball contains two free truetype fonts which is acceptable content - filenames are all ascii Needs attention: - rpmlint output is above (might be better to use a relative symlink) - good to add a reference to bug 196433 - the package should require the new fonts-japanese package rather than conflict with the old one (see http://fedoraproject.org/wiki/Packaging/Conflicts) - it should not own %{catalogue}/ since this is now owned by filesystem Suggestions: - might be nice to have a summary and description in ja too -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review