[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1516328



--- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Hidden files
  - rpmlint complains:

~~~
rubygem-guard-compat.noarch: W: hidden-file-or-dir
/usr/share/gems/gems/guard-compat-1.2.1/.rubocop_todo.yml
~~~

    but it would be probably good idea to get rid of all the hidden file by one
    sweep, e.g. to replace:

~~~
%exclude %{gem_instdir}/.gitignore
%exclude %{gem_instdir}/.rubocop.yml
%{gem_instdir}/.rubocop_todo.yml
%exclude %{gem_instdir}/.rspec
~~~

    by just single line:

~~~
%exclude %{gem_instdir}/.*
~~~

* Missing URL
  - There is no URL tag in the .spec file. There should probably be some, e.g.:

~~~
URL: https://github.com/guard/guard-compat
~~~

Otherwise the package looks good. Please fix these two nits and I'll approve
this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux