https://bugzilla.redhat.com/show_bug.cgi?id=1513733 --- Comment #2 from Christoph Junghans <junghans@xxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #1) > Looking at this now. A few starting comments: > > - Maybe use http://hpc.github.io/libcircle/ as the URL? Good point, done! > - since it's a release candidate, you should use the pre-release versioning > scheme where the release is < 1: > https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions Done. > - I'll look at other packagers, but do you think the devel package should be > broken up into devel-mpich and devel-openmpi? Done. > - you should include the docs generated with doxygen, in a separate > subpackage if necessary. Done. > - license etc need to be included Done. Spec URL: https://junghans.fedorapeople.org/libcircle.spec SRPM URL: https://junghans.fedorapeople.org/libcircle-0.2.1-0.2rc1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx