https://bugzilla.redhat.com/show_bug.cgi?id=1509590 --- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: [!] Spec file is named incorrectly. It should be named as cool-retro-term.spec [!] Non-usage of %qt5_qmake macro. Please consider using it so that our distro-wide compiler settings are applied. [!] Missing runtime dependency on qmltermwidget. QML modules do not yet have automatic dependencies, so they need to be specified. [+] Software is licensed under a valid license, and license content is included correctly [!] Notable issues from rpmlint from fedora-review: - cool-retro-term.x86_64: W: spurious-executable-perm /usr/share/man/man1/cool-retro-term.1.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
