[Bug 1517099] Review Request: perl-Export-Attrs - The Perl 6 'is export( ...)' trait as a Perl 5 attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1517099

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: Constrain `perl(Module::Build::Tiny)' dependency with `>= 0.034'
(Build.PL:5).
TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.41'
(t/author-pod-syntax.t:12).

$ rpm -qp --requires perl-Export-Attrs-0.1.0-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Attribute::Handlers)
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(PadWalker)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Export-Attrs-0.1.0-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Export::Attrs) = 0.1.0
      1 perl-Export-Attrs = 0.1.0-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Export-Attrs*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' items.

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux