https://bugzilla.redhat.com/show_bug.cgi?id=1515554 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Aivar Annamaa from comment #3) > Here's my informal review (disclaimer: I'm a newbie) > - In %install there is a comment about /usr/bin, but I don't see anything > about this location in %files section. Am I missing something? This default used to be the default when pyp2rpm is used. It's not relevant here. > - %description is same as Summary. According to > https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description > it should expand on Summary. Not sure how important this is in practice. It's not a show stopper, but it would be good to make it longer. > - Why are there exact versions listed in Requires and BuildRequires? > I think a comment explaining this would be useful. It seems the version is the same as the package's version. Is that intentional or coincidence? If intentional, I'd use %{version} instead of the hardcoded value. > - According to the packaging guidelines, separate -doc subpackage should be > created in case of large documentation. This is not the case here. > At the same time it makes sense not to duplicate the documentation > if both python2 and python3 versions of tha package are installed. > Not sure what is the right way here. This is common practice with python packages. If the doc is not large, I'd say both ways a re possible. > - I don't see why fedora-review came up with "Note: Package contains font > files". That's because it's true. List the files (use `rpm -qpf <built_doc_package>.rpm`). the fonts should be unbundled. (It's tedious, but there are packages doing it. python-notebook does it, but not for documentation.) > Is it because of sphinx_rtd_theme required by the docs? > Maybe then there should be BuildRequires: python(3)-sphinx_rtd_theme ? I believe this is pulled by default by sphinx now (not 100% sure). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
