https://bugzilla.redhat.com/show_bug.cgi?id=1515554 --- Comment #3 from Aivar Annamaa <aivar.annamaa@xxxxxxxxx> --- Here's my informal review (disclaimer: I'm a newbie) Overall: Looks like author has put lot of effort into the package. Automatic fedora-review found no issues with the package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - In %install there is a comment about /usr/bin, but I don't see anything about this location in %files section. Am I missing something? - %description is same as Summary. According to https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description it should expand on Summary. Not sure how important this is in practice. - Why are there exact versions listed in Requires and BuildRequires? I think a comment explaining this would be useful. - According to the packaging guidelines, separate -doc subpackage should be created in case of large documentation. This is not the case here. At the same time it makes sense not to duplicate the documentation if both python2 and python3 versions of tha package are installed. Not sure what is the right way here. - I don't see why fedora-review came up with "Note: Package contains font files". Is it because of sphinx_rtd_theme required by the docs? Maybe then there should be BuildRequires: python(3)-sphinx_rtd_theme ? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 17 files have unknown license. Detailed output of licensecheck in /home/aivar/review-python-certbot-dns- rfc2136/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -certbot-dns-rfc2136 , python3-certbot-dns-rfc2136 , python-certbot- dns-rfc2136-doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-certbot-dns-rfc2136-0.19.0-1.fc26.noarch.rpm python3-certbot-dns-rfc2136-0.19.0-1.fc26.noarch.rpm python-certbot-dns-rfc2136-doc-0.19.0-1.fc26.noarch.rpm python-certbot-dns-rfc2136-0.19.0-1.fc26.src.rpm python-certbot-dns-rfc2136-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-certbot-dns-rfc2136-doc/html/objects.inv python-certbot-dns-rfc2136-doc.noarch: W: file-not-utf8 /usr/share/doc/python-certbot-dns-rfc2136-doc/html/objects.inv 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python3-certbot-dns-rfc2136.noarch: W: invalid-url URL: https://github.com/certbot/certbot <urlopen error [Errno -2] Name or service not known> python-certbot-dns-rfc2136-doc.noarch: W: invalid-url URL: https://github.com/certbot/certbot <urlopen error [Errno -2] Name or service not known> python-certbot-dns-rfc2136-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-certbot-dns-rfc2136-doc/html/objects.inv python-certbot-dns-rfc2136-doc.noarch: W: file-not-utf8 /usr/share/doc/python-certbot-dns-rfc2136-doc/html/objects.inv python2-certbot-dns-rfc2136.noarch: W: invalid-url URL: https://github.com/certbot/certbot <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- python3-certbot-dns-rfc2136 (rpmlib, GLIBC filtered): python(abi) python3-acme python3-certbot python3-dns python3-setuptools python3-zope-interface python-certbot-dns-rfc2136-doc (rpmlib, GLIBC filtered): python2-certbot-dns-rfc2136 (rpmlib, GLIBC filtered): python(abi) python2-acme python2-certbot python2-dns python2-setuptools python2-zope-interface Provides -------- python3-certbot-dns-rfc2136: certbot-dns-rfc2136 python3-certbot-dns-rfc2136 python3.6dist(certbot-dns-rfc2136) python3dist(certbot-dns-rfc2136) python-certbot-dns-rfc2136-doc: python-certbot-dns-rfc2136-doc python2-certbot-dns-rfc2136: python-certbot-dns-rfc2136 python2-certbot-dns-rfc2136 python2.7dist(certbot-dns-rfc2136) python2dist(certbot-dns-rfc2136) Source checksums ---------------- https://files.pythonhosted.org/packages/source/c/certbot-dns-rfc2136/certbot-dns-rfc2136-0.19.0.tar.gz : CHECKSUM(SHA256) this package : cb47fb4cfd0ded5548411f5b1d9a50c6e8b834448e7fc5f341da34a86983de28 CHECKSUM(SHA256) upstream package : cb47fb4cfd0ded5548411f5b1d9a50c6e8b834448e7fc5f341da34a86983de28 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=1515554 Buildroot used: fedora-26-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
