https://bugzilla.redhat.com/show_bug.cgi?id=1506722 Carlos Goncalves <cgoncalves@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends On| |1507995, 1417461 --- Comment #3 from Carlos Goncalves <cgoncalves@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - Did you forget to put the Version and Release infos? Done. > - There is no %changelog entry either! Done. > - No need to complicate things, use version instead of upstream_version and > remove upstream_version definition Template client spec suggests using upstream_version [1]. Couple of existing OpenStack clients specs also defining macro upstream_version [2][3][4][5]. > - You could use the %{py2_dist/%{py3_dist macros to handle your BR and R. > See > https://fedoraproject.org/wiki/Packaging: > Python#Requires_and_BuildRequires_with_standardized_names Yes, although: a) Easier to maintain dependencies with BR and R explicitly thanks to '$ rdopkg reqcheck'. b) Consistency with other OpenStack client specs. c) Straightforward to support RDO and RHOSP, because EL7 does not support such macros AFAIK. > There is no package openstack-macros in Fedora repositories. You'll have to > package it beforehand. Replaced macro %py_req_cleanup by "rm -f {,test-}requirements.txt" as it's also not used in existing OpenStack client specs for Fedora. (In reply to Nir Magnezi from comment #2) > 1. In other packages we have, URL points to a launchpad URL. since Octavia > migrated to storyboard, perhaps the URL should be: > https://storyboard.openstack.org/#!/project/911 Good point! Indeed [1] suggests linking to launchpad. I think that is because launchpad project pages have been considered good landing pages. Would project-specific storyboard pages be a good replacement? I'd rather point to somewhere providing users with more info such as [6], [7] or [8] (because of the HTML-rendered README). > 2. You should end up with a separate RPM for tests, see the > python-neutronclient spec for reference: > https://github.com/rdo-packages/neutronclient-distgit/blob/ > 26310d84ea59c383c928be5d01d350f0e21291cd/python-neutronclient.spec#L65-L130 Yes, although python-stestr is a dependency and happens that the python-stestr RPM has a dependency issue (rhbz #1507995). Either we wait for a fix or disable -tests subpackage. [1] https://github.com/openstack-packages/openstack-example-spec/blob/master/python-exampleclient.spec [2] http://pkgs.fedoraproject.org/cgit/rpms/python-neutronclient.git/tree/python-neutronclient.spec [3] http://pkgs.fedoraproject.org/cgit/rpms/python-novaclient.git/tree/python-novaclient.spec [4] http://pkgs.fedoraproject.org/cgit/rpms/python-congressclient.git/tree/python-congressclient.spec [5] http://pkgs.fedoraproject.org/cgit/rpms/python-aodhclient.git/tree/python-aodhclient.spec [6] https://docs.openstack.org/python-octaviaclient/latest/ [7] https://docs.openstack.org/octavia/latest/ [7] https://github.com/openstack/python-octaviaclient Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1417461 [Bug 1417461] python-openstackclient: Provide a Python 3 subpackage https://bugzilla.redhat.com/show_bug.cgi?id=1507995 [Bug 1507995] Nothing provides python2-PyYAML -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
