Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pecl-memcache - Extension to work with the Memcached caching daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253579 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From matthias@xxxxxxxxxxxx 2007-08-22 09:21 EST ------- I just went through the ReviewGuidelines, double checked the license and tested a Fedora 7 x86_64 build. It all looks fine. Just two minor nitpicks : - Some sections of your spec file are separated by 2 spaces, others only by one. It would be more readable if all were separated by 2 IMHO :-) (before %prep, %build and %changelog). - It's harmless here, but you should always escape macros in comments and the %changelog, so change "use %name rather than %pecl_name" to "use %%name rather than %%pecl_name" or even simply "use name rather than pecl_name". Again, no big deal, but if some day you put some multi-line macro, it'll do nasty stuff ;-) APPROVED even as-is in any case, great work on PHP packaging, keep it up! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review