https://bugzilla.redhat.com/show_bug.cgi?id=1513512 --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Review: - mir-demos contains an icon, you need to use the gtk-update-icon-cache scriplet. See https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache Requires: hicolor-icon-theme And: %post demos /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun demos if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans demos /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - You should call /sbin/ldconfig for client-libs-debugext which contains the library libmirclient-debug-extension.so.* - mir-demos contains a desktop file, miral-shell.desktop, it should be validated in %install or %check. See: https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage BuildRequires: desktop-file-utils And: desktop-file-validate %{buildroot}/%{_datadir}/applications/miral-shell.desktop - Package should own these directories: /usr/lib64/mir, /usr/lib64/mir/tools, /usr/lib64/mir/client-platform, /usr/lib64/mir/server-platform -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
