https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #22 from Michal Ambroz <rebus@xxxxxxxxx> --- Bump to release 2.0.1 https://rebus.fedorapeople.org/SPECS/radare2.spec https://rebus.fedorapeople.org/SRPMS/radare2-2.0.1-1.fc25.src.rpm I have addressed some of the your findings (comments, license, changelog), but there is still more work to do on the area of minified JS code. The bundled JS libraries are not the core of the package functionality. These are various templates to generated beautified reports out of the binary code. I do not even know how to generate some of these in order to test the modified functionality. I understand the reasons, simply I need some more time for that. > This is clearly a bug. Their SONAME is wrong: I would not call it bug. It is just not the double linking as you would expect. You expect that there would be (compare for example with libzip.so.4.0.0): libr_reg.so.2.0.1 with soname libr_reg.so.2 libr_reg.so.2 link pointing to libr_reg.so.2.0.1 and libr_reg.so in devel package pointing to libr_reg.so.2.0.1 While they have: libr_reg.so.2.0.1 with soname libr_reg.so libr_reg.so link pointing to libr_reg.so.2.0.1 The structure is the same, just one level shallower. They use the same link for pointing to the library for runtime and for devel. The usual structure allows changing devel link while keeping the runtime link operational with old version. So you could be having trouble compiling new radare package on a machine where already is old one (not something we would need in fedora). We can think of changing that in future, but right now I do not know how to do that without breaking the stuff. > Also, please drop the last %changelog message. > tito is arguably something different from this package. Changing "tito" to "radare2" - originally I thought it is refering to some nickname. The line came from the original radare2.spec from the project (and was presumably created for the project by Pavel Odvody) so I would not like to just drop it. He deserves credit as well. Best regards Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
