https://bugzilla.redhat.com/show_bug.cgi?id=1494979 --- Comment #2 from Omer Anson <omer.anson@xxxxxxxxxxxxxxxx> --- Updated spec file according to review comments: Spec URL: https://raw.githubusercontent.com/omeranson/jsonmodels/rpm-spec/rpm/python-jsonmodels.spec SRPM URL: https://github.com/omeranson/jsonmodels/raw/rpm-spec/rpm/python-jsonmodels-2.2-1.src.rpm Description: jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON. For more examples and better description see full documentation: http://jsonmodels.rtfd.org. Fedora Account System Username: oanson Review comments that were addressed: * Make description smaller. No longer than a few lines. * Remove Group tag * Remove BuildRoot * Remove Prefix * Remove Vendor * Create %use_tests macro, and set it true iff fedora and add comment * Remove %defattr * Verify with rpmlint * Verify links with spec-tool -g * rename specfile to python-jsonmodels.spec * Rename source0 to jsonmodels-2.2.tar.gz. * Remove 'version' and 'unmangled_version' macros. Set 'Version' and use that (it's also a macro definition) * Add changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
