https://bugzilla.redhat.com/show_bug.cgi?id=1512226 --- Comment #2 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- - You should use the python macros for building and installing the package. See [1]. - The docs directory contains the sources for the package documentation, not the actual documentation. You want to either compile the docs and provide them compiled or not provide them at all (I'd prefer the first option). Also, The README and CHANGELOG files should also go in %doc since they may contain useful information for users. - Please, see [2] to set the proper Source URL for the package according to Fedora guidelines. Note that the package does not build at the moment: cd python3-flask-cors-3.0.3 /var/tmp/rpm-tmp.4frmkX: line 38: cd: python3-flask-cors-3.0.3: No such file or directory It cannot find the proper directory. This will be fixed when you address the source name issue, but it could also be addressed by passing the source dir name to %autosetup (do stick with the first option: fix the source url). When you make changes during this review, please bump the package release so I can see you can properly do so. Please, provide a koji scratch build (or a copr build) of the package so I can see your package does build without the need to build it here (I will build the package during the review, but I want to see you took the time to make sure it does build correctly). [1] https://fedoraproject.org/wiki/Packaging:Python [2] https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
