[Bug 1503175] Review Request: thonny - Python IDE for beginners

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #20 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to Aivar Annamaa from comment #18)
> Miro, I think I have fixed all the items you brought up, except %check:

Great!

> About %check:
> 
> Several of my tests are creating a Tkinter window. When I tried running the
> tests with
> 
> %check 
> py.test-3 --pyargs thonny
> 
> then those tests failed because Tkinter couldn't access the display. I
> suppose this is because of the restricted build environment and there is
> nothing to do about it.

You might want to look at Xvfb. This seams relevant
https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/N7OW5LPNJUGFHATFTNHJZC7W4V772H4O/

> When I install the package and run `py.test-3
> --pyargs thonny` manually in Terminal, then all tests pass.

When I do that, it collects 0 tests. What is the exact step by step guide?

> I hope it's OK to omit the %check for now. I'll try to organize my tests
> better in future versions so that the package builder can run at least those
> tests which doesn't use Tkinter.

Sure thing. I'd sugest marking the test with some kind of marker
https://docs.pytest.org/en/latest/mark.html

> PS. Did I understand correctly that %check is run only at package building
> time, not when user installs the package?

Exactly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux