[Bug 1511966] Review Request: qmltermwidget - a QML port of QTermWidget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1511966

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,

 - Just use:

Release:    2.20171027git%{commit_short}%{?dist}

   No dot are needed around git.

 - There's a typo in your Source0:

Source0:    %{URL}/archive/{%commit_long}/%{name}-%{commit_long}.tar.gz

   {%commit_long} → %{commit_long}

 - There is no pkgconfig(Qt5Declarative)

DEBUG util.py:458:  No matching package to install: 'pkgconfig(Qt5Declarative)'

   If I look at what qt5-qtdeclarative-devel provides:

$ dnf repoquery -l qt5-qtdeclarative-devel | grep "\.pc"
/usr/lib64/pkgconfig/Qt5Qml.pc
/usr/lib64/pkgconfig/Qt5Quick.pc
/usr/lib64/pkgconfig/Qt5QuickTest.pc
/usr/lib64/pkgconfig/Qt5QuickWidgets.pc

   It seems you already requested it with pkgconfig(Qt5Quick)

 - There's a typo in the License field:

License:    GPv2+

  Missing an L.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux