https://bugzilla.redhat.com/show_bug.cgi?id=1503175 --- Comment #18 from Aivar Annamaa <aivar.annamaa@xxxxxxxxx> --- Miro, I think I have fixed all the items you brought up, except %check: Spec URL: https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec SRPM URL: https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.16-1.fc27.src.rpm Changes: * https://bitbucket.org/plas/thonny-rpm/commits/066a4208f320c561f4983864e8eedb5abdeca048 * https://bitbucket.org/plas/thonny-rpm/commits/0e84d4abb4eb98a7464335978d43f5afe6ab11a1 About %check: Several of my tests are creating a Tkinter window. When I tried running the tests with %check py.test-3 --pyargs thonny then those tests failed because Tkinter couldn't access the display. I suppose this is because of the restricted build environment and there is nothing to do about it. When I install the package and run `py.test-3 --pyargs thonny` manually in Terminal, then all tests pass. I hope it's OK to omit the %check for now. I'll try to organize my tests better in future versions so that the package builder can run at least those tests which doesn't use Tkinter. PS. Did I understand correctly that %check is run only at package building time, not when user installs the package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
