Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-ExtUtils-MakeMaker-Coverage - Allows perl modules to check test coverage with Devel::Cover https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251998 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-08-20 23:04 EST ------- cool. Thanks for updates Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c48557fe6e6c92e2d36e2eda9ae7e746 ExtUtils-MakeMaker-Coverage-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00.load...............# Testing ExtUtils::MakeMaker::Coverage 0.05 ok t/mm_coverage...........ok t/mm_coverage_config....ok t/pod-coverage..........ok t/pod...................ok All tests successful. Files=5, Tests=39, 1 wallclock secs ( 0.34 cusr + 0.07 csys = 0.41 CPU) + exit 0 + Provides: perl(ExtUtils::MakeMaker::Coverage) = 0.05 + Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(ExtUtils::MakeMaker::Coverage) perl(File::Basename) perl(Getopt::Long) perl(base) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review