Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flpsed - WYSIWYG pseudo PostScript editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252125 ewan@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ewan@xxxxxxxxxxxxxx ------- Additional Comments From ewan@xxxxxxxxxxxxxx 2007-08-19 19:40 EST ------- Hi, I can't sponsor you, I'm afraid, so this is an entirely unofficial review but I hope it's useful: - Licence field is plain GPL; according to http://fedoraproject.org/wiki/Packaging/LicensingGuidelines it should be versioned; in this case COPYING is GPLv2, and the source makes no mention of the 'or any later version' text, so this field should read GPLv2. - rpmlint is clear except for license problem. - Buildroot is the older, now second preference version, not really a problem. (see: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473) - %files includes INSTALL which are just the generic instructions, this is considered irrelevant as per http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b - This is a GUI application, but does not include a .desktop file. (see: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop) Otherwise it looks OK to to me, and builds in mock for F7 and F-devel. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review