Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: new - A simple template system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250040 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-19 08:42 EST ------- For 1.3.10-1 * description ------------------------------------------------------- // Copyright (C) 1999 %(FULLNAME) %(EMAIL) ------------------------------------------------------- - Please use %%(FULLNAME) %%(EMAIL) so that build log does not warn as below: ------------------------------------------------------- sh: FULLNAME: command not found sh: EMAIL: command not found Installing /builddir/build/SRPMS/new-1.3.10-1.fc8.src.rpm Building target platforms: i386 Building for target i386 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.30592 ------------------------------------------------------- * Documents - The file "INSTALL" is for people who want to rebuild this package by themselves and not needed for people who want to install by rpm method. * rpmlint issues - Still some issues mentioned in the comment 6 are not fixed Also another issues are found. ------------------------------------------------------- E: new non-executable-script /usr/share/new/templates/missing/default 0644 E: new non-executable-script /usr/share/new/templates/py/default 0644 E: new non-executable-script /usr/share/new/templates/sh/default 0644 W: new undefined-non-weak-symbol /usr/lib/libnewfmt_ptrn.so.1.3.10 template_find W: new-java no-documentation E: new-java library-without-ldconfig-postin /usr/lib/libnewfmt_ptrnjava.so.1.3.10 E: new-java library-without-ldconfig-postun /usr/lib/libnewfmt_ptrnjava.so.1.3.10 E: new-java library-without-ldconfig-postin /usr/lib/libnewfmt_ptrnjni.so.1.3.10 E: new-java library-without-ldconfig-postun /usr/lib/libnewfmt_ptrnjni.so.1.3.10 W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjava.so.1.3.10 /lib/libz.so.1 W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjava.so.1.3.10 /lib/libgcc_s.so.1 W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjava.so.1.3.10 /lib/libm.so.6 W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjava.so.1.3.10 /lib/libpthread.so.0 W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjava.so.1.3.10 /lib/librt.so.1 W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjava.so.1.3.10 /lib/libdl.so.2 W: new-java undefined-non-weak-symbol /usr/lib/libnewfmt_ptrnjni.so.1.3.10 fmt_ptrn_get_keys W: new-java undefined-non-weak-symbol /usr/lib/libnewfmt_ptrnjni.so.1.3.10 fmt_ptrn_init W: new-java undefined-non-weak-symbol /usr/lib/libnewfmt_ptrnjni.so.1.3.10 fmt_ptrn_close W: new-java unused-direct-shlib-dependency /usr/lib/libnewfmt_ptrnjni.so.1.3.10 /lib/libz.so.1 W: new-devel no-documentation -------------------------------------------------------- * Summary * About /usr/share/new/templates/*/default: - Please fix the permission of these scripts or remove shebangs of these scripts. * libnewfmt_ptrnjni.so.1 and /usr/lib/libnewfmt_ptrnjava.so.1 - Please call ldconfig for these libraries (i.e. -java subpackage also must call /sbin/ldconfig on %post and %postun) * Undefined non-weak symbols - are found on libnewfmt_ptrn.so and libnewfmt_ptrnjni.so. (can be checked as below:) --------------------------------------------------------- [tasaka1@localhost ~]$ ldd -r /usr/lib/libnewfmt_ptrn.so undefined symbol: template_find (/usr/lib/libnewfmt_ptrn.so) linux-gate.so.1 => (0x00110000) libglib-2.0.so.0 => /lib/libglib-2.0.so.0 (0x0011a000) libz.so.1 => /lib/libz.so.1 (0x001e3000) libc.so.6 => /lib/libc.so.6 (0x001f6000) /lib/ld-linux.so.2 (0x80000000) --------------------------------------------------------- This is not allowed when you want to provide -devel subpackage because leaving undefined non-weak symbols causes linkage failure. * defattr - We recommend %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review