https://bugzilla.redhat.com/show_bug.cgi?id=1509568 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Not a formal review but a couple of points after reading the SPEC: - Don't add: %dir %{_datadir}/icons/hicolor/scalable %dir %{_datadir}/icons/hicolor/scalable/apps These directories should be owned by the Requires to hicolor-icon-theme - Please note last week change in the guidelines regarding Appdata. It was announced on the devel-announce mailing list: Appstream metadata guidelines were updated to reflect the new location into which appdata files should be placed. * https://fedoraproject.org/wiki/Packaging:AppData * https://pagure.io/packaging-committee/issue/704 Per the new guidelines, appdata files must now be installed in %{_datadir}/metainfo/ instead of %{_datadir}/appdata/ - You must run the Icon cache scriplet: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - Add the changelog and authors to %doc: %doc AUTHORS.md CHANGELOG.md README.md - Use this simplified URL: Source0: https://github.com/ColinDuquesnoy/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - Regarding: # Build is broken on: ExcludeArch: ppc64le ppc64 s390x Build is not "broken", MellowPlayer is using Qt Web Engine, which is only available on some arches. However this is not how you should handle it, instead we have a specific macro: ExclusiveArch: %{qt5_qtwebengine_arches} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
