[Bug 1509290] Review Request: vmod-uuid - uuid module for varnish cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1509290

Iwicki Artur <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> ---
>Group: System Environment/Daemons
>BuildRoot: ...
The "Group:" and "BuildRoot:" tags should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>URL: https://github.com/otto-de/lib%{name}.git
I think it's preferred for the "URL:" tag to point to a website that can be
visited and read by humans. (GitHub redirects the browser to the repo's
web-view, but still.)

>%if 0%{?fedora} >= 17 || 0%{?rhel} >= 7
>%license LICENSE
>%else
>%doc LICENSE
>%endif
You can replace this with just "%license LICENSE"; builders for EPEL6 handle
%licence just fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux