https://bugzilla.redhat.com/show_bug.cgi?id=1507997 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - make %{?_smp_mflags} → %make_build - make install DESTDIR=$RPM_BUILD_ROOT → %make_install - glib-compile-schemas is not needed in %postun and %posttrans for Fedora >= 24. See: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#GSettings_Schema - There should not be any %defattr(-,root,root,-) in %files - The COPYING file should be included with the %license macro, not %doc: %doc AUTHORS ChangeLog NEWS README %license COPYING - Use pkgconfig for BR when you can: BuildRequires: desktop-file-utils BuildRequires: gettext BuildRequires: pkgconfig(gsettings-desktop-schemas) BuildRequires: pkgconfig(gtk+-3.0) >= %{gtk3_version} BuildRequires: intltool BuildRequires: pkgconfig(x11) BuildRequires: pkgconfig(libsoup-2.4) BuildRequires: pkgconfig(libwnck-3.0) >= %{libwnck3_version} BuildRequires: perl-XML-Parser BuildRequires: pkgconfig(sqlite3) BuildRequires: yelp-tools - Consider adding an Appdata file: https://fedoraproject.org/wiki/Packaging:AppData -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
