Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: classads - a powerful and flexible, semi-structured representation of data https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253249 ------- Additional Comments From nsboyle@xxxxxxxxx 2007-08-17 15:31 EST ------- "Release:" number should reflect ONLY the packaging version (IE- the first time you package= Release: 1, second = Release: 2, etc etc..). It shouldn't have anything whatsoever to do with the upstream source version. This tends to fall under naming so consult http://fedoraproject.org/wiki/Packaging/NamingGuidelines Source0 URL should probably be changed to something like ftp://ftp.cs.wisc.edu/condor/classad/c++/%{name}-%{version}.tar.gz I don't know that it's required, but it'll certainly save you from forgetting to bump up the version number in Source0: if you ever bump the version of the package. AFAIK, the CHANGELOG included with the source is only used to reflect changes made to the upstream source and should not be used to document changes to the package itself (nor should it be referred to by the packages %changelog section... I believe the two are to be considered mutually exclusive). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review