https://bugzilla.redhat.com/show_bug.cgi?id=1506995 --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Net-MQTT-Simple-1.21-1.fc28.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Getopt::Long) 1 perl(IO::Socket::SSL) 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Net::MQTT::Simple) 1 perl(Net::MQTT::Simple::SSL) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/bin/perl Binary requires are almost Ok. FIX: One of the module from IO::Socket::IP or IO::Socket::INET, should be listed in run-requires. Prefer IO::Socket::IP over IO::Socket::INET. - lib/Net/MQTT/Simple.pm: 19-22 $ rpm -qp --provides perl-Net-MQTT-Simple-1.21-1.fc28.noarch.rpm | sort | uniq -c 1 perl(Net::MQTT::Simple) = 1.21 1 perl-Net-MQTT-Simple = 1.21-1.fc28 1 perl(Net::MQTT::Simple::SSL) Binary provides are Ok. $ rpmlint ./perl-Net-MQTT-Simple* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires FIX: - If you want to use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 - add BR 'make', it is used in spec file - add BR perl(strict), it is used in t/regex.t - add BR one of the modules IO::Socket::IP or IO::Socket::INET. TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. TODO: You can replace 'chmod -R u+w %{buildroot}/*' by macro '%{_fixperms} %{buildroot}' Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Package is not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
