https://bugzilla.redhat.com/show_bug.cgi?id=1507103 --- Comment #2 from Michele Baldessari <michele@xxxxxxxxxx> --- Thanks for starting this Madison :) Some quick drive-by comments: So you might want to run 'fedora-review -n kronosnet' in the folder where you have your .spec + .src.rpm kronosnet files. That will spit out a bunch of nits that we need to fix. For example: WARNING: Cannot download url: https://github.com/fabbione/kronosnet/archive/kronosnet-0.8.tar.gz WARNING: Package kronosnet-debuginfo-0.8-1.fc28 not built Once we fix the URLs: --- a/kronosnet.spec +++ b/kronosnet.spec @@ -72,8 +72,8 @@ Version: 0.8 Release: 1%{?numcomm:.%{numcomm}}%{?alphatag:.%{alphatag}}%{?dirty:.%{dirty}}%{?dist} License: GPLv2+ and LGPLv2+ Group: System Environment/Base -URL: https://github.com/fabbione/kronosnet/ -Source0: https://github.com/fabbione/kronosnet/archive/%{name}-%{version}%{?numcomm:.%{numcomm}}%{?alphatag:-%{alphatag}}%{?dirty:-%{dirty}}.tar.gz +URL: https://github.com/kronosnet/kronosnet/ +Source0: https://github.com/kronosnet/kronosnet/archive/v%{version}%{?numcomm:.%{numcomm}}%{?alphatag:-%{alphatag}}%{?dirty:-%{dirty}}.tar.gz We will need to call autogen.sh explicitely because ./configure is not shipped in the tarball. Also, I am not sure those if defined macros are working as expected, so we'll need to look into that as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
