https://bugzilla.redhat.com/show_bug.cgi?id=1505374 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- It seems that at least some of the python3 executables are not ready: $ /usr/bin/mraptor-3.6 Traceback (most recent call last): File "/usr/bin/mraptor-3.6", line 11, in <module> load_entry_point('oletools==0.51', 'console_scripts', 'mraptor')() File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 563, in load_entry_point return get_distribution(dist).load_entry_point(group, name) File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2651, in load_entry_point return ep.load() File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2305, in load return self.resolve() File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2311, in resolve module = __import__(self.module_name, fromlist=['__name__'], level=0) File "/usr/lib/python3.6/site-packages/oletools/mraptor.py", line 84, in <module> from oletools import olevba File "/usr/lib/python3.6/site-packages/oletools/olevba.py", line 237, in <module> import cStringIO ModuleNotFoundError: No module named 'cStringIO' $ /usr/bin/olevba-3.6 Traceback (most recent call last): File "/usr/bin/olevba-3.6", line 11, in <module> load_entry_point('oletools==0.51', 'console_scripts', 'olevba')() File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 563, in load_entry_point return get_distribution(dist).load_entry_point(group, name) File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2651, in load_entry_point return ep.load() File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2305, in load return self.resolve() File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2311, in resolve module = __import__(self.module_name, fromlist=['__name__'], level=0) File "/usr/lib/python3.6/site-packages/oletools/olevba.py", line 237, in <module> import cStringIO ModuleNotFoundError: No module named 'cStringIO' Dunno. I don't think it's very useful to package this. I think you should diasable those executables that crash immediately. -- A small inconsistency: - you have foo-3.6 → foo-3, but foo-2.7 → foo-2 ← foo I think the less specific name should always link to the more specific one, i.e. foo-2.7 ← foo-2 ← foo. In practice all those symlinks are provided in the same package, but at least theoretically one might install some of the less specific symlinks, e.g. in /usr/local/bin. So let's say that I install a python 3.7 version, with a foo-3.7 executable, and symlink foo-3 too this. Things would still work as expected, but there would be two foo-3 executables with different versions. I found this much cleaner when the symlinks go one way. (It's OK as is though.) OK, without further ado: - package name is OK - license is acceptable for Fedora (a combination of BSD/MIT/Python) - license is specified correctly - latest version - builds and installs OK - Provides/Requires/BuildRequires look correct - Provides bundled() have been added - fedora-review finds no issues Package is APPROVED. I see that F <= 27 has python-easygui, while rawhide has python2-easygui. You'll probably need to addjust BR to build for F27-. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
