https://bugzilla.redhat.com/show_bug.cgi?id=1505306 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - The R and BR for hicolor-icon-theme are still there… - You didn't use %{_udevrulesdir} everywhere: chmod 0644 %{buildroot}/%{_prefix}/lib/udev/rules.d/i2c_smbus.rules mv %{buildroot}/%{_prefix}/lib/udev/rules.d/i2c_smbus.rules %{buildroot}/%{_prefix}/lib/udev/rules.d/50-i2c_smbus.rules - You need to add the following BR: BuildRequires: libappstream-glib otherwise appstream-util won't work - It seems there is an error in the build script: >Install pixmaps... >/usr/bin/make -C pixmaps install >make[1]: Entering directory '/builddir/build/BUILD/I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps' >mkdir -p /builddir/build/BUILDROOT/i-nex-7.6.0-2.20170703git0c10102.fc28.x86_64/usr/share/pixmaps >/usr/bin/install -p 644 i-nex.png /builddir/build/BUILDROOT/i-nex-7.6.0-2.20170703git0c10102.fc28.x86_64/usr/share/pixmaps/ >/usr/bin/install: cannot stat '644': No such file or directory >make[1]: *** [Makefile:5: install] Error 1 The correct syntax for install is: install -p -m 644 i-nex.png /builddir/build/BUILDROOT/i-nex-7.6.0-2.20170703git0c10102.fc28.x86_64/usr/share/pixmaps/ The -m is missing so the command fails. You should probably patch it and notify upstream. Here's a patch for it: diff -up I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile.fix_build I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile --- I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile.fix_build 2017-05-24 21:16:01.000000000 +0200 +++ I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile 2017-10-23 17:10:34.223531318 +0200 @@ -18,7 +18,7 @@ install-bin: install-bin-i-nex-edid install-bin-i-nex-edid: test -d $(DESTDIR)$(bindir) || mkdir $(DESTDIR)$(bindir) - $(INSTALL) 0755 i-nex-edid $(DESTDIR)$(bindir) + $(INSTALL_DM) 0755 i-nex-edid $(DESTDIR)$(bindir) clean: @echo -e '$(ACTION_COLOR)Clean JSON$(NO_COLOR)' $(RM_COM) $(RMFILE_OPT) i-nex-edid diff -up I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile.fix_build I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile --- I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile.fix_build 2017-05-24 21:16:01.000000000 +0200 +++ I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile 2017-10-23 17:08:12.910892293 +0200 @@ -20,8 +20,8 @@ build-json: install-desktop-files: @echo -e '\033[1;32mCreate nedded dirs...\033[0m' mkdir -p $(DESTDIR)$(PREFIX)/share/applications - $(INSTALL) 0755 debian/i-nex.desktop $(DESTDIR)$(PREFIX)/share/applications/ - $(INSTALL) 0755 debian/i-nex-library.desktop $(DESTDIR)$(PREFIX)/share/applications/ + $(INSTALL_DM) 0755 debian/i-nex.desktop $(DESTDIR)$(PREFIX)/share/applications/ + $(INSTALL_DM) 0755 debian/i-nex-library.desktop $(DESTDIR)$(PREFIX)/share/applications/ install-pixmaps: diff -up I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile.fix_build I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile --- I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile.fix_build 2017-05-24 21:16:01.000000000 +0200 +++ I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile 2017-10-23 17:07:26.049011999 +0200 @@ -2,10 +2,10 @@ include ../i-nex.mk install: mkdir -p ${DESTDIR}$(PREFIX)/share/pixmaps - ${INSTALL} 644 i-nex.png $(DESTDIR)$(PREFIX)/share/pixmaps/ - ${INSTALL} 644 i-nex-16.png $(DESTDIR)$(PREFIX)/share/pixmaps/ - ${INSTALL} 644 i-nex-32.png $(DESTDIR)$(PREFIX)/share/pixmaps/ - ${INSTALL} 644 i-nex-128.png $(DESTDIR)$(PREFIX)/share/pixmaps/ + $(INSTALL_DM) 644 i-nex.png $(DESTDIR)$(PREFIX)/share/pixmaps/ + $(INSTALL_DM) 644 i-nex-16.png $(DESTDIR)$(PREFIX)/share/pixmaps/ + $(INSTALL_DM) 644 i-nex-32.png $(DESTDIR)$(PREFIX)/share/pixmaps/ + $(INSTALL_DM) 644 i-nex-128.png $(DESTDIR)$(PREFIX)/share/pixmaps/ uninstall: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
