https://bugzilla.redhat.com/show_bug.cgi?id=1505304 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - You need to add: BuildRequires: doxygen Otherwise the docs and man pages are not built. - You should disable the build of static lib: %configure --disable-static - You didn't actually remove %exclude %{_libdir}/%{name}.so. Just use: %files devel %{_bindir}/cpuid_tool %{_includedir}/%{name} %{_libdir}/%{name}.so %{_libdir}/pkgconfig/%{name}.pc %{_mandir}/man3/*.3.* The static lib %{_libdir}/%{name}.a shouldn't be included anyway. - The package uses obsolete m4 macros: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools You should patch them out and notify upstream about it. Here's a patch for it: diff -up libcpuid-57298c650cd3cb326d9357cdb9b9dd51d60007bb/configure.ac.fix_obsolete_m4s libcpuid-57298c650cd3cb326d9357cdb9b9dd51d60007bb/configure.ac --- libcpuid-57298c650cd3cb326d9357cdb9b9dd51d60007bb/configure.ac.fix_obsolete_m4s 2017-05-04 14:36:19.000000000 +0200 +++ libcpuid-57298c650cd3cb326d9357cdb9b9dd51d60007bb/configure.ac 2017-10-23 15:11:43.130346420 +0200 @@ -36,7 +36,7 @@ AC_SUBST([LIBCPUID_VERSION_INFO]) AC_PROG_CC m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) AC_C_CONST -AM_PROG_LIBTOOL +LT_INIT AM_CPPFLAGS="$CPPFLAGS" AC_CHECK_HEADERS([stdint.h]) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
