[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #2 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> %global debug_package %{nil}
No, this is rutning off debug while you really need it.

> URL:            https://github.com/multiplexd/%{name}
My personal preference is to have links clickable ;)

> Source0:        https://github.com/multiplexd/%{name}/archive/v%{version}.tar.gz
Give it meaningful name and you can also simplify it:
%{url}/archive/v%{version}/%{name}-%{version}.tar.gz

> BuildRequires:  libbsd
libbsd-devel is enough

> make %{?_smp_mflags}
%make_build

> rm -rf $RPM_BUILD_ROOT
Not needed

> install -p -m 755 %{_builddir}/%{name}-%{version}/%{name} %{buildroot}%{_bindir}
install -p -m 755 %{name} %{buildroot}%{_bindir}/%{name}

---

And the main and big problem is that CFLAGS and LDFLAGS are ignored, you need
to patch Makefile.. Or just stop using makefile ;)

This is what I see from build.log: gcc brightlight.c -o brightlight -O2
-fstack-protector-strong -lbsd

while it should be: gcc brightlight.c -o brightlight -O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -lbsd

I've created patch for upstream which you can use:
https://github.com/multiplexd/brightlight/pull/1

This will fix problem with debuginfo thing you have.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux