https://bugzilla.redhat.com/show_bug.cgi?id=1398922 Michal Schmidt <mschmidt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschmidt@xxxxxxxxxx --- Comment #21 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- (In reply to Benjamin Kircher from comment #13) > > 1) These BR are not needed: gcc > BR removed. It should stay. See https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires When rpmlint and the Guidelines disagree, side with the Guidelines. rpmlint is not always up to date. > %files > %{_bindir}/uftrace > %{_libdir}/%{name}/libmcount*.so Your package should own the directory %{_libdir}/%{name} itself, not just the file in it. > %{_mandir}/man1/uftrace*.1* > %{_sysconfdir}/bash_completion.d/uftrace Please place packaged completions under %{_datadir}/bash_completion/completions/ and keep /etc for the administrator. The current practice is to co-own the completion directories, though I would like to see that changed (bug #1504616). > * Wed Jun 28 2017 Benjamin Kircher <benjamin.kircher@xxxxxxxxx> - 0.7-1 > - New upstream release > - Use %configure macro Beware of macro expansion inside the changelog. Use double percent signs to prevent expansion, like this: - Use %%configure macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
