Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: setroubleshoot-plugins - analysis plugins for setroubleshoot https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251545 ------- Additional Comments From tmraz@xxxxxxxxxx 2007-08-16 17:29 EST ------- First notes: Incorrect license tag: GPL - should be GPLv2+ instead. rpmlint -v ~/download/setroubleshoot-plugins-1.10.0-1.fc7.src.rpm I: setroubleshoot-plugins checking W: setroubleshoot-plugins tag-in-description BuildRequires: The Buildrequires: python is misplaced into the description. W: setroubleshoot-plugins strange-permission setroubleshoot-plugins.spec 0600 Please assign 0644 permissions. W: setroubleshoot-plugins mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 49) Is it really necessary to use the leading tabs in the changelog? rpmlint -v setroubleshoot-plugins-1.10.0-1.fc8.noarch.rpm I: setroubleshoot-plugins checking E: setroubleshoot-plugins zero-length /usr/share/doc/setroubleshoot-plugins-1.10.0/TODO E: setroubleshoot-plugins zero-length /usr/share/doc/setroubleshoot-plugins-1.10.0/NEWS E: setroubleshoot-plugins zero-length /usr/share/doc/setroubleshoot-plugins-1.10.0/ChangeLog E: setroubleshoot-plugins zero-length /usr/share/doc/setroubleshoot-plugins-1.10.0/README Perhaps these empty files shouldn't be included in the package? W: setroubleshoot-plugins tag-in-description BuildRequires: W: setroubleshoot-plugins incoherent-version-in-changelog 1.10.1-1 1.10.0-1.fc8 Changelog mentions 1.10.1 Version is 1.10.0. W: setroubleshoot-plugins empty-%postun Shouldn't the setroubleshootd be notified through dbus on uninstall too? In the %post - the dbus-send output+stderr probably should be redirected to /dev/null and also the command safeguarded for non-zero exit status by '||:' As I see there is setroubleshoot repository on hosted.fedoraproject.org would it be possible to also host upstream tarballs there? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review