https://bugzilla.redhat.com/show_bug.cgi?id=1210993 James Hogarth <james.hogarth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(denis.arnaud_fedo | |ra@xxxxxxx) --- Comment #17 from James Hogarth <james.hogarth@xxxxxxxxx> --- This is obviously quite a complex spec to review so bear with me. If we can coordinate to be on IRC at the same time at some point that would make life simpler... but for now there will need to be some back and forth ;) For now I think the best way to get through this is to have a back and forth with changes to align the spec with policy, and then when we get to that point issue the formal review. Otherwise the ability to see the issues to work on will end up being somewhat blurred by the review template and more difficult to follow overall. 1) The spec has conditionals to build for old fedora (less than F25, going back to pre F18 even) and also for EPEL5. Since these are long since blocked in koji please remove all conditional sections that are no longer relevant - ie that won't be actively used in any build intended. This is required for legibility - see section 9.2 of guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Legibility 2) The %define needs to be justified, otherwise it needs to be replaced by %global - https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define 3) The BuildRoot tag should be removed - https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections 4) The %install needs the rm -rf of the build root removed (same link as 3) 5) Doesn't that cd in %install right after the rm effectively result in a cd to `pwd`? Seems like it should be unnecessary based on current rpmbuild behaviour. 6) There should be no %clean section (same link as 3) 7) There should be no defattr in %files unless a non-default value is required - https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions 8) The license file should be %license and not %doc I know this was pretty much just a copy and small port to relocate boost157 from the appropriate spec in Fedora at the time, but there's a few changes we should make to align it with current guidelines... especially since EPEL5 is long since dead at this point and Tibbs put in so much work to bring macros like %license to EPEL6 ;) Overall, since it is a port from a recentish Fedora, it's in a pretty good state which is fortunate for us :) If you can please address the points above and then we can do the formal review itself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
