Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bootchart - a utility for profiling the boot process https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889 caillon@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|green@xxxxxxxxxx |caillon@xxxxxxxxxx CC| |green@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From caillon@xxxxxxxxxx 2007-08-16 13:50 EST ------- Comandeering this package review... % rpmlint *rpm W: bootchart invalid-license GPL W: bootchart invalid-license GPL W: bootchart-logger non-standard-group System/Boot W: bootchart-logger invalid-license GPL * Please choose one of GPL+, GPLv2, GPLv2+, GPLv3, GPLv3+. See various mailing list threads about it. Also, I'll note that one of the files you install (/usr/share/doc/bootchart-0.9/LICENSE.compress.txt) mentions the Apache License. Might want to figure out what's up with that. * System Environment/Base seems to be the right group for the logger * Preserve your file timestamps by using the -p flag to install(1) * There's a new preferred buildroot of the day, it appears, though you're using the second-best version of it. Just figured I'd point that out since it humors me. * I'll assume this builds under mock. If it doesn't you'll find out when you try to build into koji. * Also, is this package really useful without the logger subpackage? Might consider killing the subpackage. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review