https://bugzilla.redhat.com/show_bug.cgi?id=1341662 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #19 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- It seems you actually need the dependency on jekyll, build fails otherwise. warning: Macro expanded in comment on line 18: %{name}-%{shortcommit}.tar.xz + package name is OK + latest version + license is acceptable for Fedora (GPLv2+) + builds and installs OK + Provides/Requires/BuildRequires look OK (with Requires:rubygem(jekyll)) + fedora-review finds no issues Package is APPROVED. Note: it is possible to make the binary package noarch by creating a subpackage and making it BuildArch:noarch and moving all the files to it. I'll attach a patch, but I'm not sure if this is worth the trouble — use it or ignore it as you see fit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
