https://bugzilla.redhat.com/show_bug.cgi?id=1502016 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello mosquito, - update-desktop-database is not needed anymore in Fedora 25 or later. See https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#desktop-database Just use: %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - I don't think this dependency should be so strict: BuildRequires: pkgconfig(dtkwidget) = 2.0 Maybe use >=. - You must validate the .desktop file: desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop - You must add the followinq Require for icons: Requires: hicolor-icon-theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
