[Bug 1388908] Review Request: python-flask-bootstrap - Python flask bootstrap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1388908

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
            Summary|Review Request:             |Review Request:
                   |python-Flask-Bootstrap -    |python-flask-bootstrap -
                   |Python flask bootstrap      |Python flask bootstrap
              Flags|                            |fedora-review+



--- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Hmm, fedora-review has trouble. It fails with "path too long" exception.
Whatever.

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly (according to setup.py, individual files have
no headers)
+ latest version
+ builds and installs OK
+ P/BR/R look mostly OK, see below
+ modern python packaging template is used
- no %check, but not required

So the only thing that is missing is Provides for bundled js/css stuff.
You certainly need:

Provides: bundled(jquery)

but maybe also some additional stuff, please look at the .js files and identify
if there's something that should have another Provides:bundled() annotation.

Oh, and also please fix the Summary to be something different then the package
name (and then update the title of this ticket to match).

Package is APPROVED. Please update Provides and Summary before importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux