[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1485458



--- Comment #21 from Martin Brandenburg <martin@xxxxxxxxxxxxxxxxxxxxx> ---
(In reply to Jonathan Dieter from comment #20)
> Thanks so much, this is looking better.  I'm enclosing the rpmlint output
> because there are a number of problems that need to be investigated.
> 
> You can ignore the shared-lib-calls-exit warnings, the
> script-without-shebang warning, the no-manual-page-for-binary warning
> (assuming you're not planning to write some new man pages), the
> useless-provides for the debuginfo subpackage, and the invalid-url warning.  
> 
> Please check the rest of them and either fix them or explain why they're
> there.
> 
> Rpmlint
> -------
> Checking: orangefs-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-debuginfo-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-devel-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-server-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-fuse-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-2.9.6-0.4.20171004svn.fc28.src.rpm
> orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/libofs.so.2.9.6
> exit@GLIBC_2.2.5
> orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/liborangefs.so.2.9.6
> exit@GLIBC_2.2.5
> orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpvfs2.so.2.9.6
> exit@GLIBC_2.2.5
> orangefs.x86_64: E: script-without-shebang
> /usr/lib64/liborangefsposix.so.2.9.6
> orangefs.x86_64: W: manual-page-warning
> /usr/share/man/man1/pvfs2-drop-caches.1.gz 13: warning: numeric expression
> expected (got `f')
> orangefs.x86_64: W: manual-page-warning
> /usr/share/man/man1/pvfs2-fs-dump.1.gz 15: warning: numeric expression
> expected (got `m')

These are fixed.

> orangefs.x86_64: W: no-manual-page-for-binary ofs_cp
> orangefs.x86_64: W: no-manual-page-for-binary ofs_graphite_driver
> orangefs.x86_64: W: no-manual-page-for-binary ofs_rm
> orangefs.x86_64: W: no-manual-page-for-binary ofs_setdirhint

I wrote a whole bunch of manpages before submitting for the first time,
so I will write more.

> orangefs-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
> orangefs-devel.x86_64: W: no-dependency-on orangefs/orangefs-libs/liborangefs

Fixed.

> orangefs-devel.x86_64: W: only-non-binary-in-usr-lib

I'm guessing this is the linker script...

> orangefs-devel.x86_64: W: no-documentation
> orangefs-devel.x86_64: W: no-manual-page-for-binary pvfs2-config
> orangefs-server.x86_64: W: conffile-without-noreplace-flag
> /etc/orangefs/orangefs.conf
> orangefs-server.x86_64: W: conffile-without-noreplace-flag /etc/pvfs2tab

Fixed.

> orangefs-fuse.x86_64: W: only-non-binary-in-usr-lib
> orangefs-fuse.x86_64: W: no-documentation
> orangefs-fuse.x86_64: W: no-manual-page-for-binary pvfs2fuse
> orangefs.src:26: W: unversioned-explicit-provides libpvfs2.so()(64bit)
> orangefs.src:28: W: unversioned-explicit-provides libofs.so()(64bit)
> orangefs.src:28: W: unversioned-explicit-provides liborangefs.so()(64bit)
> orangefs.src:28: W: unversioned-explicit-provides libpvfs2.so()(64bit)
> orangefs.src:39: W: macro-in-comment %{version}

This will go away when the real release is made, but until then I don't
want to lose the real URL.

> orangefs.src:289: W: macro-in-%changelog %doc

I should write 'percent-doc' I guess?

> orangefs.src: E: specfile-error warning: bogus date in %changelog: Mon Oct
> 11 2017 Martin Brandenburg <martin@xxxxxxxxxxxxxxxxxxxxx> -
> 2.9.6-0.4.20171004svn

I guess it is Wednesday.

> 6 packages and 0 specfiles checked; 3 errors, 24 warnings.
> 
> 
> 
> 
> Rpmlint (debuginfo)
> -------------------
> Checking: orangefs-debuginfo-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-server-debuginfo-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
>           orangefs-fuse-debuginfo-2.9.6-0.4.20171004svn.fc28.x86_64.rpm
> orangefs-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
> orangefs-server-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
> 3 packages and 0 specfiles checked; 2 errors, 0 warnings.
> 
> 
> 
> 
> 
> Rpmlint (installed packages)
> ----------------------------
> sh: /usr/bin/python: No such file or directory

I don't know where this comes from?

> orangefs-fuse.x86_64: W: invalid-url URL: http://www.orangefs.org/ <urlopen
> error [Errno -2] Name or service not known>

I assume the network is blocked wherever this is run?

> orangefs-fuse.x86_64: W: only-non-binary-in-usr-lib
> orangefs-fuse.x86_64: W: no-documentation
> orangefs-fuse.x86_64: W: no-manual-page-for-binary pvfs2fuse
> orangefs-fuse-debuginfo.x86_64: W: invalid-url URL: http://www.orangefs.org/
> <urlopen error [Errno -2] Name or service not known>
> orangefs-debuginfo.x86_64: W: invalid-url URL: http://www.orangefs.org/
> <urlopen error [Errno -2] Name or service not known>
> orangefs-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
> orangefs-devel.x86_64: W: no-dependency-on orangefs/orangefs-libs/liborangefs
> orangefs-devel.x86_64: W: invalid-url URL: http://www.orangefs.org/ <urlopen
> error [Errno -2] Name or service not known>
> orangefs-devel.x86_64: W: only-non-binary-in-usr-lib
> orangefs-devel.x86_64: W: no-documentation
> orangefs-devel.x86_64: W: no-manual-page-for-binary pvfs2-config
> orangefs-server.x86_64: W: invalid-url URL: http://www.orangefs.org/
> <urlopen error [Errno -2] Name or service not known>
> orangefs-server.x86_64: W: conffile-without-noreplace-flag
> /etc/orangefs/orangefs.conf
> orangefs-server.x86_64: W: conffile-without-noreplace-flag /etc/pvfs2tab
> orangefs.x86_64: W: invalid-url URL: http://www.orangefs.org/ <urlopen error
> [Errno -2] Name or service not known>
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libofs.so.2.9.6 /lib64/librt.so.1
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libofs.so.2.9.6 /lib64/libm.so.6
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libofs.so.2.9.6 /lib64/liblmdb.so.0.0.0
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libofs.so.2.9.6 /lib64/libssl.so.1.1
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libofs.so.2.9.6 /lib64/libcrypto.so.1.1
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libofs.so.2.9.6 /lib64/libibverbs.so.1
> orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/libofs.so.2.9.6
> exit@GLIBC_2.2.5
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/liborangefs.so.2.9.6 /lib64/librt.so.1
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/liborangefs.so.2.9.6 /lib64/libm.so.6
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/liborangefs.so.2.9.6 /lib64/liblmdb.so.0.0.0
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/liborangefs.so.2.9.6 /lib64/libssl.so.1.1
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/liborangefs.so.2.9.6 /lib64/libcrypto.so.1.1
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/liborangefs.so.2.9.6 /lib64/libibverbs.so.1

This is the only new non-trivial thing I see.  It is fixed now.

> orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/liborangefs.so.2.9.6
> exit@GLIBC_2.2.5
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpvfs2.so.2.9.6 /lib64/liblmdb.so.0.0.0
> orangefs.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpvfs2.so.2.9.6 /lib64/libssl.so.1.1
> orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpvfs2.so.2.9.6
> exit@GLIBC_2.2.5
> orangefs.x86_64: E: script-without-shebang
> /usr/lib64/liborangefsposix.so.2.9.6
> orangefs.x86_64: W: manual-page-warning
> /usr/share/man/man1/pvfs2-drop-caches.1.gz 13: warning: numeric expression
> expected (got `f')
> orangefs.x86_64: W: manual-page-warning
> /usr/share/man/man1/pvfs2-fs-dump.1.gz 15: warning: numeric expression
> expected (got `m')
> orangefs.x86_64: W: no-manual-page-for-binary ofs_cp
> orangefs.x86_64: W: no-manual-page-for-binary ofs_graphite_driver
> orangefs.x86_64: W: no-manual-page-for-binary ofs_rm
> orangefs.x86_64: W: no-manual-page-for-binary ofs_setdirhint
> orangefs-server-debuginfo.x86_64: W: invalid-url URL:
> http://www.orangefs.org/ <urlopen error [Errno -2] Name or service not known>
> orangefs-server-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
> 7 packages and 0 specfiles checked; 3 errors, 39 warnings.

Git: https://github.com/omnibond/orangefs-fedora
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22391406
Spec: http://dev.orangefs.org/2017/marbran/1011/2/orangefs.spec
SRPM:
http://dev.orangefs.org/2017/marbran/1011/2/orangefs-2.9.6-0.5.20171011svn.fc26.src.rpm

I now have

$ rpmlint *.src.rpm
orangefs.src:35: W: macro-in-comment %{version}
orangefs.src: W: invalid-url Source0: orangefs-2.9.6.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint orangefs orangefs-debuginfo orangefs-devel orangefs-fuse
orangefs-server
orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/libofs.so.2.9.6
exit@GLIBC_2.2.5
orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/liborangefs.so.2.9.6
exit@GLIBC_2.2.5
orangefs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpvfs2.so.2.9.6
exit@GLIBC_2.2.5
orangefs.x86_64: E: script-without-shebang /usr/lib64/liborangefsposix.so.2.9.6
orangefs.x86_64: W: no-manual-page-for-binary ofs_cp
orangefs.x86_64: W: no-manual-page-for-binary ofs_graphite_driver
orangefs.x86_64: W: no-manual-page-for-binary ofs_rm
orangefs.x86_64: W: no-manual-page-for-binary ofs_setdirhint
orangefs-devel.x86_64: W: only-non-binary-in-usr-lib
orangefs-devel.x86_64: W: no-documentation
orangefs-devel.x86_64: W: no-manual-page-for-binary pvfs2-config
orangefs-fuse.x86_64: W: no-documentation
orangefs-fuse.x86_64: W: no-manual-page-for-binary pvfs2fuse
5 packages and 0 specfiles checked; 1 errors, 12 warnings.

So I've put all the documentation in the main package, but some of it is
focused at developers.  This is things like an overview of the design
of various subsystems.  It may not be required reading but anyone
intending to deploy in production should probably read most of it.
Should any of this go in the -devel subpackage instead?

That leaves only-non-binary-in-usr-lib, which I think is the linker
script.  What should I do about it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux