https://bugzilla.redhat.com/show_bug.cgi?id=1499569 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Use a more meaningful name for your archive, with: Source0: https://github.com/twilio/twilio-python/archive/%{version}/%{name}-%{version}.tar.gz - I don't think this is necessary: # sitelib for noarch packages, sitearch for others (remove the unneeded one) %{!?__python2: %global __python2 %__python} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} python2_sitelib is already defined in Fedora. - Use the appropriate python macros: %{__python2} setup.py build ⇒ %py2_build %{__python3} setup.py build ⇒ %py3_build %{__python3} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT ⇒ %py3_install %{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT ⇒ %py2_install - add the examples directory to %doc: %doc README.rst examples - python2-twilio.noarch: E: description-line-too-long C The Twilio REST SDK simplifies the process of making calls using the Twilio REST API. Split your description to stay under 80 characters per line. - python-twilio.src:26: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 26) Use either spaces or tabs, not both. - You could use the %{py2_dist/%{py3_dist macros to handle your Python dependencies. See https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names BuildRequires: python2-devel BuildRequires: %{py2_dist nose} BuildRequires: %{py2_dist pytz} BuildRequires: %{py2_dist six} BuildRequires: %{py2_dist mock} BuildRequires: python2-jwt BuildRequires: %{py2_dist requests} %if %{with python3} BuildRequires: python3-devel BuildRequires: %{py3_dist nose} BuildRequires: %{py3_dist pytz} BuildRequires: %{py3_dist six} BuildRequires: %{py3_dist mock} BuildRequires: python3-jwt BuildRequires: %{py3_dist requests} %endif # with python3 %description %{desc} #python2 subpackage %package -n python2-twilio Summary: %{sum} Requires: %{py2_dist six} Requires: %{py2_dist requests} Requires: python2-jwt Requires: %{py2_dist pytz} %{?python_provide:%python_provide python2-twilio} %description -n python2-twilio %{desc} #python3 subpackage %if %{with python3} %package -n python3-twilio Summary: %{sum} Requires: %{py3_dist six} Requires: %{py3_dist requests} Requires: python3-jwt Requires: %{py3_dist pytz} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
