[Bug 1497349] Review Request: alignak - Alignak python Monitoring tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1497349



--- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Use a more meaningful name for your archive, with:

Source0:       
https://github.com/Alignak-monitoring/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

 - There's a typo here:

Buildarch:      noarch

   It should be "BuildArch".

 - Your ini and cfg configuration files are marked as executable:

alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/alignak.cfg
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/alignak.cfg
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/alignak.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/alignak.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/arbiterd.ini
alignak-arbiter.noarch: E: script-without-shebang
/etc/alignak/daemons/arbiterd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/brokerd.ini
alignak-arbiter.noarch: E: script-without-shebang
/etc/alignak/daemons/brokerd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/pollerd.ini
alignak-arbiter.noarch: E: script-without-shebang
/etc/alignak/daemons/pollerd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/reactionnerd.ini
alignak-arbiter.noarch: E: script-without-shebang
/etc/alignak/daemons/reactionnerd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/receiverd.ini
alignak-arbiter.noarch: E: script-without-shebang
/etc/alignak/daemons/receiverd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/schedulerd.ini
alignak-arbiter.noarch: E: script-without-shebang
/etc/alignak/daemons/schedulerd.ini
alignak-reactionner.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/reactionnerd.ini
alignak-reactionner.noarch: E: script-without-shebang
/etc/alignak/daemons/reactionnerd.in
alignak-scheduler.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/schedulerd.ini
alignak-scheduler.noarch: E: script-without-shebang
/etc/alignak/daemons/schedulerd.ini
alignak-poller.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/pollerd.ini
alignak-poller.noarch: E: script-without-shebang
/etc/alignak/daemons/pollerd.ini
alignak-broker.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/brokerd.ini
alignak-broker.noarch: E: script-without-shebang
/etc/alignak/daemons/brokerd.ini
alignak-receiver.noarch: E: executable-marked-as-config-file
/etc/alignak/daemons/receiverd.ini
alignak-receiver.noarch: E: script-without-shebang
/etc/alignak/daemons/receiverd.ini

  Remove the executable bits (i.e. chmod 0644) and notify upstream about this.

 - Remove the shebangs from your Python scripts:

alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_arbiter.py /usr/bin/env
python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_arbiter.py 644
/usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_broker.py /usr/bin/env
python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_broker.py 644 /usr/bin/env
python
alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_environment.py
/usr/bin/env python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_environment.py 644
/usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_poller.py /usr/bin/env
python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_poller.py 644 /usr/bin/env
python
alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_reactionner.py
/usr/bin/env python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_reactionner.py 644
/usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_receiver.py /usr/bin/env
python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_receiver.py 644
/usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/alignak/bin/alignak_scheduler.py /usr/bin/env
python
alignak-common.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/alignak/bin/alignak_scheduler.py 644
/usr/bin/env python

   See
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries

  - Mark file in run as ghost:

alignak-common.noarch: W: non-ghost-in-run /run/alignak

A file or directory in the package is located in /run. Files installed in this
directory should be marked as %ghost and created at runtime to work properly
in tmpfs /run setups.

i.e.

%ghost %{_rundir}/%{name}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux