[Bug 1499109] Review Request: perl-Log-Journald - perl Log:: Journald module for faster logging to journald

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1499109



--- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> ---
1.) The SPEC file needs some modernizing, in particular removal of obsolete
bits:

> -BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BuildRoot tag is no longer used.

> -Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

I don't think MODULE_COMPAT makes sense anymore -- libperl now has a properly
versioned SONAME and thus a sufficient dependency gets generated.

>  %install
> -rm -rf $RPM_BUILD_ROOT

The buildroot shouldn't be cleaned anymore.

> -%clean
> -rm -rf $RPM_BUILD_ROOT

The %clean section is no longer used.

> -%defattr(-,root,root,-)

%defattr is for making the files owned by root is not needed anymore.

2.) The source file you've bundled with your src.rpm does nor correspond to the
upstream source.

Please turn the changes into a Patch file and apply it with %patch macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux