https://bugzilla.redhat.com/show_bug.cgi?id=1498991 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Group: is not needed in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - You should run the tests. [!]: Test suite of the library should be run. There's a test provided here: https://github.com/apalmblad/ruby-shadow/tree/master/test Here's an outline of what needs to be done: Source1: tests-%{version}.tar.bz2 Source10: dl-tests.sh BuildRequires: rubygem(minitest) %prep gem unpack %{SOURCE0} %setup -q -D -T -n %{gem_name}-%{version} gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec %patch0 -p0 %setup -q -T -D -a 1 -n %{gem_name}-%{version} %check pushd .%{gem_instdir} ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)' popd dl-tests.sh is a script used by the nodejs guys to download tests from Github, it works well with our case. You can grab a copy here https://src.fedoraproject.org/rpms/nodejs-base/blob/master/f/dl-tests.sh Then run it to generate tests-%{version}.tar.bz2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
