https://bugzilla.redhat.com/show_bug.cgi?id=1499408 Athos Ribeiro <athoscribeiro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- > upstream CMakeLists.txt has 3.0-alpha and also soname has 3.0.0 version Probably mistyped when grep'ing for it. > > > - The LICENSE file should be shipped in the -devel sub-package as well > No because it requires main package You are right: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > > > - The include/hidapi/hidapi.h file seems to be licensed under GPLv3, taken for another repository. Shouldn't and 'and' tag for GPLv3 be added in the License tag? > > It is not installed and I will make sure to remove it in %prep during import OK > > - Finally, rpmlint complains about unused shard lib dependency for libm. Was this required by the compiler? Just making sure you are aware. > > I will report a bug to upstream. However, this is not blocker. No, it is not :) Package looks good, approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
