Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: util-linux-ng (util-linux replacement) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252046 ------- Additional Comments From kzak@xxxxxxxxxx 2007-08-15 07:28 EST ------- (In reply to comment #2) > Blockers: > * Licensing: > - "If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package, must be included as documentation." Fixed, added README.licensing and licenses/* to %doc. > * BuildRoot value is invalid, see Packaging/Guidelines Fixed. > * Inconsistent use of both BuildRoot and %{buildroot} Fixed. > * Use %config(noreplace) - at least for 60-raw.rules, I'm not sure about the > files in /etc/pam.d/ Fixed, the "noreplace" used for pam.d/ files too. > * Obsoletes: clock - seems to be pre-Fedora, can be removed IMHO. Fixed (removed). > Same for timeconfig. Fixed (removed). > * mnt_test_sysinfo.c:74: warning: right shift count >= width of type Fixed (upstream). > * BuildRequires: sed is unnecessary Fixed. > * does floppy really need %makeinstall? No, fixed. > * why is the [ "%{_infodir}" != "%{_prefix}/info" ... ] section necessary? Fixed (removed). > * why is (gzip -9nf ${RPM_BUILD_ROOT}%{_infodir}/ipc.info) necessary? Fixed (removed). Please, try a new version: http://people.redhat.com/kzak/util-linux/util-linux-ng-2.13-0.53.fc8.x86_64.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review