Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alsa-firmware - Firmware for several ALSA-supported sound card https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217259 ------- Additional Comments From rpm@xxxxxxxxxx 2007-08-14 17:07 EST ------- (In reply to comment #13) Thanks for the review, Jason. > W: alsa-firmware strange-permission alsa-firmware.spec 0660 > Kind of weird and quite insecure on many systems. Should be 644. I don't > know if this matters at all once things are in CVS. I'm sure it doesn't. > W: alsa-firmware mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1) > I don't see this as a problem; fix it if you like. Sorted. (but see below) > W: alsa-firmware incoherent-version-in-changelog 0:1.0.12-1 1.0.12-1.fc8 > rpmlint doesn't like seeing the epoch there, but I think this is an rpmlint > issue. Looks like it. > This does not install, due to an unsatisfied dependency on alsa-tools-firmware > >= 1.0.12. I guess this is a subpackage of alsa-tools which is currently > disabled. You own alsa-tools so it should be pretty easy to get it turned on. Yes. It's disabled as a subpackage of alsa-tools for the exact reason that having the -firmware package without alsa-firmware makes no sense. As soon as we're reasonably happy with this package, I'll enable alsa-tools-firmware. > The specfile does not consistently use macros. If you want to use %{__make} and > %{__rm}, you need to use them everywhere and also use %{__mv} and %{__cp}. Sorted. > The current version seems to be 1.0.14, which came out in June. Any reason > not to package it? Nope, updated. Will post updated packages when I get a chance to build and test them. It seems that just dropping in 1.0.14 to the current spec leads to all kinds of craziness. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review