https://bugzilla.redhat.com/show_bug.cgi?id=706199 Mattia Verga <mattia.verga@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mattia.verga@xxxxxxxx --- Comment #8 from Mattia Verga <mattia.verga@xxxxxxxx> --- Hi Michael, if you can provide an updated version I can do the review. Just some notices for the moment: - Better use pkgconfig for BuildRequires. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_based_on_pkg-config - The contents of the buildroot SHOULD NOT be removed in the first line of %install. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - You don't need the %defattr directive. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
