https://bugzilla.redhat.com/show_bug.cgi?id=1417628 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - As before, list of things not needed in Fedora: + Group: System Environment/Libraries + BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + rm -rf $RPM_BUILD_ROOT + %clean + %defattr(-,root,root,-) - The LICENSE file should be under %license, not %doc: %files -n mingw32-%{name1} -f mingw32-confuse.lang %doc AUTHORS README.md %license LICENSE - Please update to version 3.2.1 to follow main package version. You'll need to add BR for handling translations: BuildRequires: mingw32-gettext BuildRequires: mingw64-gettext And libconfuse-1.dll becomes libconfuse-2.dll: %files -n mingw32-%{name1} -f mingw32-confuse.lang %doc AUTHORS README.md %license LICENSE %doc doc/html %{mingw32_bindir}/libconfuse-2.dll %{mingw32_includedir}/confuse.h %{mingw32_libdir}/libconfuse.dll.a %{mingw32_libdir}/pkgconfig/libconfuse.pc %files -n mingw64-%{name1} -f mingw64-confuse.lang %doc AUTHORS README.md %license LICENSE %doc doc/html %{mingw64_bindir}/libconfuse-2.dll %{mingw64_includedir}/confuse.h %{mingw64_libdir}/libconfuse.dll.a %{mingw64_libdir}/pkgconfig/libconfuse.pc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
